Skip to content

chore(worker): remove BeforeRun and AfterRun interface #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2022
Merged

chore(worker): remove BeforeRun and AfterRun interface #46

merged 1 commit into from
Mar 28, 2022

Conversation

appleboy
Copy link
Member

fix: #45

Signed-off-by: Bo-Yi Wu appleboy.tw@gmail.com

@appleboy appleboy added the enhancement New feature or request label Mar 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2022 •
edited
Loading

Codecov Report

Merging #46 (0cced01) into master (f2b7091) will increase coverage by 1.87%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   84.41%   86.29%   +1.87%     
==========================================
  Files          10       10              
  Lines         430      416      -14     
==========================================
- Hits          363      359       -4     
+ Misses         60       52       -8     
+ Partials        7        5       -2
Flag Coverage Δ
go-1.13 85.57% <ø> (+1.39%) ⬆️
go-1.14 85.57% <ø> (+1.39%) ⬆️
go-1.15 85.57% <ø> (+1.15%) ⬆️
go-1.16 86.29% <ø> (+2.11%) ⬆️
go-1.17 85.57% <ø> (+1.39%) ⬆️
go-1.18 85.57% <ø> (+1.39%) ⬆️
ubuntu-latest 86.29% <ø> (+1.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
consumer.go 90.29% <ø> (-0.37%) ⬇️
queue.go 87.50% <ø> (+4.16%) ⬆️
worker_empty.go 42.85% <ø> (+20.63%) ⬆️
worker_message.go 86.95% <ø> (-1.05%) ⬇️
worker_task.go 83.33% <ø> (-1.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2b7091...0cced01. Read the comment docs.

@appleboy
chore(worker): remove BeforeRun and AfterRun interface
0cced01 
fix: #45

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@appleboy appleboy merged commit 8af744c into master Mar 28, 2022
@appleboy appleboy deleted the worker branch March 28, 2022 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove BeforeRun and AfterRun in worker interface
2 participants
@appleboy @codecov-commenter